-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PyTest fixtures and updated mainloop to properly compile #1901
Conversation
…void mixing config fixtures. Set the montecarlo_main_loop to recompile itself on the first iteration ot set proper config options
Before a pull request is accepted, it must meet the following criteria:
|
/azp run update-refdata |
/azp refdata-compare |
Azure Pipelines successfully started running 1 pipeline(s). |
Command 'refdata-compare' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
/azp run compare-refdata |
Azure Pipelines successfully started running 1 pipeline(s). |
Build succeeded 0432498 |
/azp run compare-refdata |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1901 +/- ##
=======================================
Coverage 61.17% 61.18%
=======================================
Files 69 69
Lines 7331 7332 +1
=======================================
+ Hits 4485 4486 +1
Misses 2846 2846
Continue to review full report at Codecov.
|
Build succeeded f954904 |
added in a special fixture for the montecarlo_1e5 model tests as to a void mixing config fixtures. Set the montecarlo_main_loop to recompile itself on the first iteration ot set proper config options
Test for numba 1e5 model was failing when run on it's own but not when run as part of the test suite. This was caused by the single packet seed setting incorrectly setting every packet to the same seed, which was removed. This indicated a larger problem where the montecarlo main loop was not properly being updated with the config changes after subsequent runs, so a change was added to recompile the main loop on the first iteration of each tardis run.
Motivation and context
Tests failing inconsistently
How has this been tested?
Type of change
Checklist