Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Black #1888

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Pin Black #1888

merged 2 commits into from
Feb 2, 2022

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Feb 2, 2022

Black had a major update due to which pipelines are failing.

Description

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1888 (6f8884c) into master (60b76ef) will not change coverage.
The diff coverage is n/a.

❗ Current head 6f8884c differs from pull request most recent head 7acbfb3. Consider uploading reports for the commit 7acbfb3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1888   +/-   ##
=======================================
  Coverage   62.55%   62.55%           
=======================================
  Files          68       68           
  Lines        7127     7127           
=======================================
  Hits         4458     4458           
  Misses       2669     2669           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b76ef...7acbfb3. Read the comment docs.

@wkerzendorf wkerzendorf merged commit c705946 into tardis-sn:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants