Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing links on contributing page #1865

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

isaacgsmith
Copy link
Member

Description

Fixes links here:
https://tardis-sn.github.io/tardis/contributing/CONTRIBUTING.html

Examples

Fixed page:
https://smithis7.github.io/tardis/branch/link_fix_doc/contributing/CONTRIBUTING.html

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1865 (ab0b00a) into master (f24be9a) will increase coverage by 4.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
+ Coverage   57.65%   62.12%   +4.46%     
==========================================
  Files          66       66              
  Lines        6809     6809              
==========================================
+ Hits         3926     4230     +304     
+ Misses       2883     2579     -304     
Impacted Files Coverage Δ
tardis/tardis/simulation/base.py 83.79% <0.00%> (+0.46%) ⬆️
tardis/tardis/visualization/plot_util.py 100.00% <0.00%> (+6.25%) ⬆️
tardis/tardis/montecarlo/montecarlo_numba/base.py 32.14% <0.00%> (+7.14%) ⬆️
tardis/tardis/base.py 75.00% <0.00%> (+17.85%) ⬆️
tardis/tardis/visualization/tools/sdec_plot.py 85.97% <0.00%> (+76.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24be9a...ab0b00a. Read the comment docs.

@wkerzendorf wkerzendorf merged commit bf9b708 into tardis-sn:master Jan 21, 2022
@isaacgsmith isaacgsmith deleted the link_fix_doc branch January 25, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants