Convert quantities to arrays when plotting in SDEC plot

[atharva-2001]

This fixes the docs build that was caused due to the new matplotlib release.

Description

Using quantities with matplotlib's fill_between method was causing an error. This PR changes quantities to arrays, just when plotting, everywhere in the SDEC plot so that no problems arise later as well.

Motivation and context

How has this been tested?

• Testing pipeline.
• Other.

Examples

Link to a failed documentation build
working docs build
Type of change

• Bug fix.
• New feature.
• Breaking change.
• None of the above.

Checklist

• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • (optional) I have built the documentation on my fork following the instructions.
• I have assigned and requested two reviewers for this pull request.

[codecov]

Codecov Report

Merging #1832 (0382a34) into master (c34beca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1832   +/-   ##
=======================================
  Coverage   58.04%   58.04%           
=======================================
  Files          66       66           
  Lines        6747     6747           
=======================================
  Hits         3916     3916           
  Misses       2831     2831           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c34beca...0382a34. Read the comment docs.

[tardis-bot]

Before a pull request is accepted, it must meet the following criteria:

• Is the necessary information provided?
• Is this a duplicate PR?
  • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
  • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
• Does it pass existing tests and are new tests provided if required?
  • The test coverage should not decrease, and for new features should be close to 100%.
• Is the code tidy?
  • No unnecessary print lines or code comments.

[jamesgillanders]

this fixes the problem, but do we want to do this, or pin the matplotlib version?

[isaacgsmith]

this fixes the problem, but do we want to do this, or pin the matplotlib version?

We definitely want this. Pinning the matplotlib version was a backup in case this problem was not easy enough to fix.

[isaacgsmith]

My only concern here is do we allow users to use different units when plotting? And either way, we should probably have the units printed on the axes, something like this.

[jaladh-singhal]

Thanks!

[jaladh-singhal]

My only concern here is do we allow users to use different units when plotting? And either way, we should probably have the units printed on the axes, something like this.

I think that we infer unit to be shown on axes from quantity. If not, then that's case for another issue/PR @smithis7 @atharva-2001 - it's out of scope for this PR.

[isaacgsmith]

Looks good