Change virtual spectrum spawn range start value to 1 #1794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following warning:
by setting the
virtual_spectrum_spawn_range
in the montecarlo.yml file from 0 to 1.Description
The error is caused due to these lines as mentioned here
because we are converting wavelength to frequency and the wavelength is zero. Any other number apart from 0 here should fix the warning.
The same warning can be replicated using this code:
Motivation and context
Resolves #1724
How has this been tested?
Examples
Removing this warning also allows progress bars to update seamlessly in the console, without having to disable the warnings. Earlier the console output was something like this:
Now the progress bars update seamlessly because the warning is not displayed with each iteration.
Type of change
Checklist