-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Custom Abundance Widget code #1784
Restructure Custom Abundance Widget code #1784
Conversation
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
==========================================
- Coverage 58.42% 58.35% -0.07%
==========================================
Files 66 66
Lines 6684 6702 +18
==========================================
+ Hits 3905 3911 +6
- Misses 2779 2791 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for restructuring it.
The notebook works fine too, the error messages just don't show up correctly - not sure if it's related to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it breaks add shells functionality
This PR aims to restructure the code of custom abundance widget as mentioned in #1777.
Description
CustomAbundanceWidgetData
class to store the data which will be edited in the widget.data
attribute, aCustomAbundanceWidgetData
instance, to organize data inCustomAbundanceWidget
andDensityEditor
.CustomAbundanceWidget
instance from aCustomAbundanceWidgetData
instance.Motivation and context
Since the widget has integrated more information than before, the separation of the data and the widget enables the module more organized and easier to be developed and maintained. Also, it would be easier to implement tests as well as new TARDIS model in the future.
How has this been tested?
Examples
Type of change
Checklist