Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse legend in Plasma Convergence Plots #1772

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

atharva-2001
Copy link
Member

This PR reverses the order of legends in Plasma Convergence plots so that the recent-most iteration shows up first.

Description

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Peek 2021-08-06 17-48

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #1772 (14ce483) into master (1c3322b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1772   +/-   ##
=======================================
  Coverage   62.65%   62.65%           
=======================================
  Files          65       65           
  Lines        6036     6036           
=======================================
  Hits         3782     3782           
  Misses       2254     2254           
Impacted Files Coverage Δ
...dis/tardis/visualization/tools/convergence_plot.py 88.67% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3322b...14ce483. Read the comment docs.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@jaladh-singhal jaladh-singhal merged commit 02789fc into tardis-sn:master Aug 12, 2021
atharva-2001 added a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Reverse legend in plasma convergence plots

* [build docs]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants