Fixed IPython Displaying the Plasma Stratification (Table) even when the Logger is turned Off #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhruvSondhi
requested review from
andrewfullard,
Rodot-,
wkerzendorf and
epassaro
|
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1739 +/- ##
=======================================
Coverage 61.87% 61.87%
=======================================
Files 63 63
Lines 5852 5852
=======================================
Hits 3621 3621
Misses 2231 2231
Continue to review full report at Codecov.
|
DhruvSondhi
force-pushed
the
fix_jupyter_display_log
branch
from
335233a to
af756ea
Compare
DhruvSondhi
force-pushed
the
fix_jupyter_display_log
branch
from
ee06c8f to
f1e4fe2
Compare
DhruvSondhi
force-pushed
the
fix_jupyter_display_log
branch
from
f1e4fe2 to
521b6b6
Compare
epassaro
reviewed
Jul 19, 2021
| import warnings | ||
| import pyne.data | ||
|
|
There was a problem hiding this comment.
Just to demarcate the different levels of imports. Native library imports, imports from external modules, etc
epassaro
approved these changes
Jul 19, 2021
andrewfullard
approved these changes
Jul 20, 2021
DhruvSondhi
added a commit
to DhruvSondhi/tardis
that referenced
this pull request
Aug 1, 2021
…the Logger is turned Off (tardis-sn#1739) * Fixed Ipython Display showing up even when the logger is turned off * [build docs]
DhruvSondhi
added a commit
to DhruvSondhi/tardis
that referenced
this pull request
Aug 9, 2021
…the Logger is turned Off (tardis-sn#1739) * Fixed Ipython Display showing up even when the logger is turned off * [build docs]
DhruvSondhi
added a commit
to DhruvSondhi/tardis
that referenced
this pull request
Aug 9, 2021
…the Logger is turned Off (tardis-sn#1739) * Fixed Ipython Display showing up even when the logger is turned off * [build docs]
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
…the Logger is turned Off (tardis-sn#1739) * Fixed Ipython Display showing up even when the logger is turned off * [build docs]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a bug that had been introduced when we merged #1684. Currently, the Plasma Stratification table is displayed even when the logger is turned off. This needed to be fixed. I have added the
IPython Applogger for considering the log level status when configuring the logger. This fixes the bug.Description
Motivation and context
How has this been tested?
Examples
This is the Current bug.
This is the fixed version.
Type of change
Checklist
Preview Available here: https://dhruvsondhi.github.io/tardis/branch/fix_jupyter_display_log/io/optional/logging_configuration.html