TARDIS Grid #1738
Merged
TARDIS Grid #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Before a pull request is accepted, it must meet the following criteria:
|
|
You may want to consider adding logging messages or passthrough handling for logging through run_tardis |
|
I still need to write some tests for this PR. |
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
==========================================
+ Coverage 61.87% 62.65% +0.78%
==========================================
Files 63 65 +2
Lines 5852 6036 +184
==========================================
+ Hits 3621 3782 +161
- Misses 2231 2254 +23
Continue to review full report at Codecov.
|
Added kwarg pass through so that users can specify run_tardis() kwargs. |
andrewfullard
approved these changes
Jul 22, 2021
Rodot-
approved these changes
Jul 26, 2021
| ---------- | ||
| configFile : str | ||
| path to TARDIS yml file. | ||
| gridFrame : pandas.core.frame.DataFrame |
There was a problem hiding this comment.
Possibly do some type-checking here? Could get weird if someone accidentally passes in a numpy array or a list
There was a problem hiding this comment.
I don't think it's necessary since there's effectively duck typing since the grid relies on .iloc[] for accessing rows.
| """ | ||
|
|
||
| def __init__(self, configFile, gridFrame): | ||
| try: |
There was a problem hiding this comment.
Perhaps do type-checking here rather than exceptions?
DhruvSondhi
pushed a commit
to DhruvSondhi/tardis
that referenced
this pull request
Aug 1, 2021
* experimental notebook * init grid dataframe * config changes * added grid module * updated test * added docstrings * Added grid_row_to_model() class function. * Added docs for grid [build docs] * [build docs] * [build docs] * [build docs] * [build docs] * added grid doc to sidebar. [build docs] * Added tests * black formatting * renamed to base.py * cleared output so notebook is run when building docs * added kwarg pass through for run_tardis kwargs. * Fixed docstring Co-authored-by: Marc Williamson <[email protected]>
DhruvSondhi
pushed a commit
to DhruvSondhi/tardis
that referenced
this pull request
Aug 9, 2021
* experimental notebook * init grid dataframe * config changes * added grid module * updated test * added docstrings * Added grid_row_to_model() class function. * Added docs for grid [build docs] * [build docs] * [build docs] * [build docs] * [build docs] * added grid doc to sidebar. [build docs] * Added tests * black formatting * renamed to base.py * cleared output so notebook is run when building docs * added kwarg pass through for run_tardis kwargs. * Fixed docstring Co-authored-by: Marc Williamson <[email protected]>
DhruvSondhi
pushed a commit
to DhruvSondhi/tardis
that referenced
this pull request
Aug 9, 2021
* experimental notebook * init grid dataframe * config changes * added grid module * updated test * added docstrings * Added grid_row_to_model() class function. * Added docs for grid [build docs] * [build docs] * [build docs] * [build docs] * [build docs] * added grid doc to sidebar. [build docs] * Added tests * black formatting * renamed to base.py * cleared output so notebook is run when building docs * added kwarg pass through for run_tardis kwargs. * Fixed docstring Co-authored-by: Marc Williamson <[email protected]>
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* experimental notebook * init grid dataframe * config changes * added grid module * updated test * added docstrings * Added grid_row_to_model() class function. * Added docs for grid [build docs] * [build docs] * [build docs] * [build docs] * [build docs] * added grid doc to sidebar. [build docs] * Added tests * black formatting * renamed to base.py * cleared output so notebook is run when building docs * added kwarg pass through for run_tardis kwargs. * Fixed docstring Co-authored-by: Marc Williamson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new module for generating grids of TARDIS simulation parameters and functionality facilitating the running of large numbers of simulations.
Motivation and context
The grid streamlines running and saving large grids of simulation parameters. It will make it very easy to generate grids from basic uniform abundances and then modify the models in systematic ways to add complexity.
How has this been tested?
Examples
A thorough example is in the docs under /io/grid/
Type of change
Checklist