Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma ray propagation #1698

Merged
merged 147 commits into from
Jun 7, 2022

Conversation

andrewfullard
Copy link
Contributor

Description

This cleans up the previous PR and consists of:

  • Montecarlo code to propagate decay products in ejecta (photons only)
  • Handling of immediate positron decay
  • Some unit tests
  • A little documentation

Motivation and context

This code is the first step in late-phase SNe Ia simulations in TARDIS

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Notebook included in PR
Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

andrewfullard and others added 30 commits April 15, 2021 11:17
This cleans up the previous PR and consists of:
* Montecarlo code to propagate decay products in ejecta (photons only)
* Handling of immediate positron decay
* Some unit tests
* A little documentation
Now returns values in seconds
Also output energy deposition time
Changed energy output to a dataframe.
This cleans up the previous PR and consists of:
* Montecarlo code to propagate decay products in ejecta (photons only)
* Handling of immediate positron decay
* Some unit tests
* A little documentation
@andrewfullard andrewfullard marked this pull request as ready for review May 16, 2022 15:19
Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll approve once black passes

tardis/energy_input/calculate_opacity.py Show resolved Hide resolved
tardis/energy_input/calculate_opacity.py Show resolved Hide resolved
tardis/energy_input/calculate_opacity.py Show resolved Hide resolved
tardis/energy_input/calculate_opacity.py Outdated Show resolved Hide resolved
tardis/energy_input/energy_source.py Show resolved Hide resolved
tardis/energy_input/energy_source.py Show resolved Hide resolved
tardis/energy_input/energy_source.py Show resolved Hide resolved
tardis/energy_input/energy_source.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #1698 (992fe6f) into master (0205add) will decrease coverage by 1.79%.
The diff coverage is 28.85%.

❗ Current head 992fe6f differs from pull request most recent head ee905cb. Consider uploading reports for the commit ee905cb to get more accurate results

@@            Coverage Diff             @@
##           master    #1698      +/-   ##
==========================================
- Coverage   60.13%   58.34%   -1.80%     
==========================================
  Files          70       76       +6     
  Lines        8108     8599     +491     
==========================================
+ Hits         4876     5017     +141     
- Misses       3232     3582     +350     
Impacted Files Coverage Δ
...dis/montecarlo/montecarlo_numba/formal_integral.py 53.87% <ø> (ø)
tardis/plasma/properties/atomic.py 55.73% <0.00%> (-0.45%) ⬇️
tardis/plasma/properties/continuum_processes.py 35.75% <0.00%> (ø)
tardis/montecarlo/montecarlo_numba/base.py 29.75% <7.14%> (-2.07%) ⬇️
...dis/montecarlo/montecarlo_numba/numba_interface.py 34.90% <15.38%> (-1.32%) ⬇️
tardis/energy_input/gamma_ray_grid.py 19.60% <19.60%> (ø)
tardis/energy_input/gamma_ray_interactions.py 20.40% <20.40%> (ø)
tardis/energy_input/energy_source.py 27.63% <27.63%> (ø)
tardis/io/atom_data/base.py 81.81% <28.00%> (-7.90%) ⬇️
tardis/energy_input/util.py 32.30% <32.30%> (ø)
... and 3 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andrewfullard
Copy link
Contributor Author

Some of the docstring failures are confusing. It claims 7 functions in e.g. calculate_opacity.py but there is definitely only 6.

@andrewfullard andrewfullard merged commit 63028ac into tardis-sn:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants