-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamma ray propagation #1698
Gamma ray propagation #1698
Conversation
This cleans up the previous PR and consists of: * Montecarlo code to propagate decay products in ejecta (photons only) * Handling of immediate positron decay * Some unit tests * A little documentation
Now returns values in seconds
Also output energy deposition time
Changed energy output to a dataframe.
This cleans up the previous PR and consists of: * Montecarlo code to propagate decay products in ejecta (photons only) * Handling of immediate positron decay * Some unit tests * A little documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'll approve once black passes
Codecov Report
@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
- Coverage 60.13% 58.34% -1.80%
==========================================
Files 70 76 +6
Lines 8108 8599 +491
==========================================
+ Hits 4876 5017 +141
- Misses 3232 3582 +350
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Some of the docstring failures are confusing. It claims 7 functions in e.g. calculate_opacity.py but there is definitely only 6. |
Description
This cleans up the previous PR and consists of:
Motivation and context
This code is the first step in late-phase SNe Ia simulations in TARDIS
How has this been tested?
Examples
Notebook included in PR
Type of change
Checklist