-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding mu and r to virtual packet logging #1696
Adding mu and r to virtual packet logging #1696
Conversation
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1696 +/- ##
==========================================
- Coverage 61.29% 61.09% -0.20%
==========================================
Files 63 63
Lines 5792 5814 +22
==========================================
+ Hits 3550 3552 +2
- Misses 2242 2262 +20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
* added r and mu to vpacket logging * fixing problem with merge conflict * fixing test failure * making documentation
This allows virtual packet logging to track the initial propagation direction and radius of the virtual packets.
Description
If virtual packet logging is turned on, the list of initial propagation directions and radii of the virtual packets are respectively accessible via
MontecarloRunner.virt_packet_initial_mus
andMontecarloRunner.virt_packet_initial_rs
.Motivation and context
This will be helpful with visualizing the virtual packets, as well as with analyzing them.
How has this been tested?
Examples
Type of change
Checklist