Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create profiling directory #1691

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Conversation

KevinCawley
Copy link
Contributor

@KevinCawley KevinCawley commented Jul 5, 2021

Add a notebook about profiling TARDIS based on parameters, and made a directory to house the profiling information.

Description

Motivation and context

Feature

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1691 (30090c8) into master (7994739) will not change coverage.
The diff coverage is n/a.

❗ Current head 30090c8 differs from pull request most recent head 83f04e0. Consider uploading reports for the commit 83f04e0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1691   +/-   ##
=======================================
  Coverage   61.26%   61.26%           
=======================================
  Files          63       63           
  Lines        5798     5798           
=======================================
  Hits         3552     3552           
  Misses       2246     2246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7994739...83f04e0. Read the comment docs.

@andrewfullard
Copy link
Contributor

Can you link to your documentation build for this branch?

@KevinCawley
Copy link
Contributor Author

It's currently failing due to a version error which is trying to be fixed.

@KevinCawley
Copy link
Contributor Author

@yuyizheng1112
Copy link
Contributor

There's blank in the documentation page here, can this be removed?

@KevinCawley
Copy link
Contributor Author

Not as far as I know. It is the display output of snakeviz, but it doesn't render when the documentation is built.

@andrewfullard andrewfullard merged commit 7d3899e into tardis-sn:master Jul 12, 2021
@KevinCawley KevinCawley deleted the profiling branch July 13, 2021 13:08
@KevinCawley KevinCawley restored the profiling branch July 13, 2021 13:08
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Create profiling directory

* Update to notebook, [build docs]

* [build docs]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants