-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling Repository on Binder #1678
Enabling Repository on Binder #1678
Conversation
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1678 +/- ##
=======================================
Coverage 61.89% 61.89%
=======================================
Files 62 62
Lines 5732 5732
=======================================
Hits 3548 3548
Misses 2184 2184 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Is the
cd
command needed? If that's true, why not doingcd ..
? It's unclear what's the$HOME
dir forbinder
(it's difficult to track what's $HOME for every CI/CD service!). Using the latter it's more clear, the script is going to the parent directory before executing the command. -
Try
install
instead ofdevelop
, it's preferred. -
Add a new blank line at the end of the file.
All of those changes have been made and binder still works! I seemingly overcomplicated the |
I actually have a few different ideas on this that are contingent on me getting a few packages working. For now I think we should leave |
* making files needed for binder build * Testing Ezequiel's comments in postBuild * Putting binder in develop mode
This allows for the TARDIS repository to be built on binder, which will in turn allow for the running of TARDIS online.
You can see the binder built on my fork here.
Type of change
Checklist