Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Repository on Binder #1678

Merged
merged 3 commits into from
Jul 1, 2021

Conversation

isaacgsmith
Copy link
Member

This allows for the TARDIS repository to be built on binder, which will in turn allow for the running of TARDIS online.

You can see the binder built on my fork here.

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #1678 (70162f1) into master (c47a3df) will not change coverage.
The diff coverage is n/a.

❗ Current head 70162f1 differs from pull request most recent head 089358b. Consider uploading reports for the commit 089358b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1678   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          62       62           
  Lines        5732     5732           
=======================================
  Hits         3548     3548           
  Misses       2184     2184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47a3df...089358b. Read the comment docs.

Copy link
Member

@epassaro epassaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is the cd command needed? If that's true, why not doing cd ..? It's unclear what's the $HOME dir for binder (it's difficult to track what's $HOME for every CI/CD service!). Using the latter it's more clear, the script is going to the parent directory before executing the command.

  • Try install instead of develop, it's preferred.

  • Add a new blank line at the end of the file.

@isaacgsmith
Copy link
Member Author

  • Is the cd command needed? If that's true, why not doing cd ..? It's unclear what's the $HOME dir for binder (it's difficult to track what's $HOME for every CI/CD service!). Using the latter it's more clear, the script is going to the parent directory before executing the command.
  • Try install instead of develop, it's preferred.
  • Add a new blank line at the end of the file.

All of those changes have been made and binder still works! I seemingly overcomplicated the cd part.

@isaacgsmith isaacgsmith requested a review from epassaro June 30, 2021 15:41
@epassaro
Copy link
Member

@smithis7

Are you interested in implementing a binder badge on the nbsphinx prolog like this?

I think it's better than have the binder badge on README.rst.

If you are interested, see their conf.py.

@isaacgsmith
Copy link
Member Author

@smithis7

Are you interested in implementing a binder badge on the nbsphinx prolog like this?

I think it's better than have the binder badge on README.rst.

If you are interested, see their conf.py.

I actually have a few different ideas on this that are contingent on me getting a few packages working. For now I think we should leave conf.py as it is but possibly change it in the future.

@andrewfullard andrewfullard merged commit 36104de into tardis-sn:master Jul 1, 2021
@isaacgsmith isaacgsmith deleted the 2nd-binder-attempt branch July 2, 2021 17:37
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* making files needed for binder build

* Testing Ezequiel's comments in postBuild

* Putting binder in develop mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants