-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure codecov #1645
configure codecov #1645
Conversation
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
==========================================
- Coverage 67.13% 61.98% -5.15%
==========================================
Files 73 62 -11
Lines 6100 5695 -405
==========================================
- Hits 4095 3530 -565
- Misses 2005 2165 +160 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ironic that this fails codecov itself
* add codecov.yml * enable patch report again * rewrite coveragerc with wildcards * remove unnecessary lines * skip scripts folder * add version.py * add default comment on header * do not ignore scripts folder * remove analysis script
Description
codecov
configuration..coveragerc
based on Coverage sample configuration file.I found tests from
visualization
andmontecarlo_numba
were taken into account to measure coverage, that's not right!. Tests always are 100% covered (all tests lines are executed during tests, lol) so now we have a lower but more realistic coverage. This was discovered by using better wildcards.Summarizing,
coverage
moved from 73 to 60 files thanks to modifying.coveragerc
:conftest.py
at the root of the packagecmfgen2tardis.py
scriptvisualization
montecarlo_numba
+ 1conftests.py
Motivation and context
Codecov is failing too often even while PRs are not changing source files.
How has this been tested?
Examples
Type of change
Checklist