Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure codecov #1645

Merged
merged 9 commits into from
Jun 14, 2021
Merged

configure codecov #1645

merged 9 commits into from
Jun 14, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 9, 2021

Description

  • Minimum codecov configuration.
  • Rewrote .coveragerc based on Coverage sample configuration file.

I found tests from visualization and montecarlo_numba were taken into account to measure coverage, that's not right!. Tests always are 100% covered (all tests lines are executed during tests, lol) so now we have a lower but more realistic coverage. This was discovered by using better wildcards.

Summarizing, coverage moved from 73 to 60 files thanks to modifying .coveragerc:

  • 1 conftest.py at the root of the package
  • 1 cmfgen2tardis.py script
  • 2 tests from visualization
  • 8 tests from montecarlo_numba + 1 conftests.py

Motivation and context
Codecov is failing too often even while PRs are not changing source files.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jun 9, 2021

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #1645 (378a41d) into master (8ceacc0) will decrease coverage by 5.14%.
The diff coverage is n/a.

❗ Current head 378a41d differs from pull request most recent head 1a78bf8. Consider uploading reports for the commit 1a78bf8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1645      +/-   ##
==========================================
- Coverage   67.13%   61.98%   -5.15%     
==========================================
  Files          73       62      -11     
  Lines        6100     5695     -405     
==========================================
- Hits         4095     3530     -565     
- Misses       2005     2165     +160     
Impacted Files Coverage Δ
tardis/tardis/scripts/cmfgen2tardis.py 0.00% <0.00%> (ø)
...ntecarlo_numba/tests/test_numba_formal_integral.py
...s/montecarlo/montecarlo_numba/tests/test_packet.py
...rlo/montecarlo_numba/tests/test_numba_interface.py
...dis/montecarlo/montecarlo_numba/tests/test_base.py
...ntecarlo/montecarlo_numba/tests/test_macro_atom.py
...tecarlo/montecarlo_numba/tests/test_interaction.py
tardis/tardis/conftest.py
...rdis/montecarlo/montecarlo_numba/tests/conftest.py
.../montecarlo/montecarlo_numba/tests/test_vpacket.py
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ceacc0...1a78bf8. Read the comment docs.

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironic that this fails codecov itself

.coveragerc Show resolved Hide resolved
@andrewfullard andrewfullard merged commit ec164dd into tardis-sn:master Jun 14, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* add codecov.yml

* enable patch report again

* rewrite coveragerc with wildcards

* remove unnecessary lines

* skip scripts folder

* add version.py

* add default comment on header

* do not ignore scripts folder

* remove analysis script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants