Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Glossary #1642

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Adding Glossary #1642

merged 4 commits into from
Jun 29, 2021

Conversation

J-Je0ng
Copy link
Contributor

@J-Je0ng J-Je0ng commented Jun 8, 2021

Description
Added the beginnings of a glossary to zreferences.rst with terms Chianti, metastable, Synapps, TOML, YAML.

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jun 9, 2021

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #1642 (6f83ce5) into master (1d7ce51) will not change coverage.
The diff coverage is n/a.

❗ Current head 6f83ce5 differs from pull request most recent head c810a67. Consider uploading reports for the commit c810a67 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1642   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          62       62           
  Lines        5732     5732           
=======================================
  Hits         3548     3548           
  Misses       2184     2184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7ce51...c810a67. Read the comment docs.

@isaacgsmith isaacgsmith requested a review from KevinCawley June 18, 2021 12:34
@J-Je0ng J-Je0ng marked this pull request as ready for review June 18, 2021 12:34
@KevinCawley
Copy link
Contributor

Can you check the relevant boxes in the description?

@andrewfullard andrewfullard requested a review from Rodot- June 22, 2021 14:39
@andrewfullard
Copy link
Contributor

@Rodot- can you fix the merge conflict?

@KevinCawley
Copy link
Contributor

The new merge adds an extra space at line 12 that doesn't seem to have any value to me. I can see the space after, but not before unless it helps with rst errors.

@andrewfullard andrewfullard merged commit c47a3df into tardis-sn:master Jun 29, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* added glossary

* added more terms

* added more terms and definitions, linked some terms to glossary

Co-authored-by: Jinyoung Jeong <[email protected]>
Co-authored-by: Jack O'Brien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants