Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move zenodo pipeline to GA #1595

Merged
merged 7 commits into from
Jun 7, 2021
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented May 29, 2021

Description

  • Move Zenodo metadata generation to GA.
  • The push job requires merging to be tested, maybe needs some tweaking.
  • The citation guidelines section in docs is updated when documentation is built.

Motivation and context

We want this feature ASAP.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #1595 (996470a) into master (267906d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1595   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          73       73           
  Lines        6150     6150           
=======================================
  Hits         4133     4133           
  Misses       2017     2017           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267906d...996470a. Read the comment docs.

@wkerzendorf
Copy link
Member

should we merge this already?

@epassaro
Copy link
Member Author

should we merge this already?

No. I needed to leave in a hurry and forgot to mark it as draft.

@epassaro epassaro marked this pull request as draft May 30, 2021 01:54
@epassaro epassaro marked this pull request as ready for review June 4, 2021 23:42
@andrewfullard andrewfullard marked this pull request as draft June 7, 2021 19:23
@epassaro epassaro marked this pull request as ready for review June 7, 2021 21:15
@wkerzendorf
Copy link
Member

@adrn thanks for the fix :-)

@wkerzendorf wkerzendorf merged commit bd9a126 into tardis-sn:master Jun 7, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* create workflow

* comment out push job

* final changes;

* fix typo

* auto update cite when building docs

* do not run on forks

* add debug step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants