-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port tardis_opacities script from tardisanalysis #1580
Conversation
Ported over opacities script from old tardis analysis
Codecov Report
@@ Coverage Diff @@
## master #1580 +/- ##
==========================================
- Coverage 67.20% 61.93% -5.28%
==========================================
Files 73 62 -11
Lines 6147 5729 -418
==========================================
- Hits 4131 3548 -583
- Misses 2016 2181 +165
Continue to review full report at Codecov.
|
@unoebauer this is the one I was talking about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great job @MarkMageeAstro - great to get this code updated and moved across to the main TARDIS repo. Happy for this to be merged, once a second reviewer signs off! Keep up the good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to merge it, we can just add @unoebauer as co-author by adding Co-authored by: [email protected]
at the end of squash commit message.
(I found this mail from git history - it's linked to his GitHub account)
This reverts commit 5941658.
* Create opacities.py Ported over opacities script from old tardis analysis * Black formatting * Remove header information
)" (tardis-sn#1677) This reverts commit 5941658.
Description
This PR is to copy over the existing tardis opacity script from the tardisanalysis repository. The tardis opacity script was originally written by @unoebauer.
The opacity script allows for the easy calculation of the following properties:
Motivation and context
tardisanalysis will eventually be closed. This is to keep the code current with tardis.
How has this been tested?
Comparisons with older version of the code.
Examples
The following snippet of code can be used to generate the plot shown below.
Type of change
Checklist