Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor changes to compare refdata pipeline #1578

Merged
merged 2 commits into from
May 20, 2021
Merged

minor changes to compare refdata pipeline #1578

merged 2 commits into from
May 20, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented May 20, 2021 •
edited
Loading

Description

  • Move bokeh installation step

Motivation and context

How has this been tested?

  • Testing pipeline.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@epassaro epassaro marked this pull request as draft May 20, 2021 16:33
@epassaro epassaro requested a review from andrewfullard May 20, 2021 16:36
@codecov
Copy link

codecov bot commented May 20, 2021 •
edited
Loading

Codecov Report

Merging #1578 (835f0e7) into master (8e5ffe1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1578   +/-   ##
=======================================
  Coverage   67.19%   67.19%           
=======================================
  Files          73       73           
  Lines        6146     6146           
=======================================
  Hits         4130     4130           
  Misses       2016     2016

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5ffe1...835f0e7. Read the comment docs.

@epassaro epassaro marked this pull request as ready for review May 20, 2021 18:31
@andrewfullard andrewfullard merged commit 4aec164 into tardis-sn:master May 20, 2021
Molkree
Molkree reviewed May 22, 2021
View reviewed changes
tardis/__init__.py

if sys.version_info < (3, 8):
if sys.version_info < (3, 8, 3):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epassaro, oh, I think this check is not needed at all. pickle5 is only available on < 3.8 through conda, the whole tardis environment now resolves to Python 3.7 after #1566 because of this (macOS AND Linux).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data is already pickled with 3.8, so yes, we need this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm missing something, can you point at the workflow with Python 3.8, please?

atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
@epassaro
minor changes to compare refdata pipeline (tardis-sn#1578)
068794f 
* move bokeh step

* use exact python version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molkree Molkree Molkree left review comments

@andrewfullard andrewfullard andrewfullard approved these changes

Assignees
No one assigned
Labels
bugfix 🪲 CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epassaro @Molkree @andrewfullard