Fixing issues with Citations & Label references in Docs

[DhruvSondhi]

Fixes issues with citations & labels for documentation generation

Description

Citations & Label referencing in the current documentation do not work as intended.
This PR aims to fix this :)

Motivation and context

Citations are now referenced correctly
Labels now point to the correct part of the documentation

How has this been tested?

• Testing pipeline.
• Other. Local Testing

Type of change

• Bug fix.
• New feature.
• Breaking change.
• None of the above.

Checklist

• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • (optional) I have built the documentation on my fork following the instructions.
• I have assigned and requested two reviewers for this pull request.

[codecov]

Codecov Report

Merging #1577 (b8f619d) into master (7eca324) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1577   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          73       73           
  Lines        6147     6147           
=======================================
  Hits         4131     4131           
  Misses       2016     2016           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eca324...b8f619d. Read the comment docs.

[isaacgsmith]

Everything looks good -- there were three more broken citations if you're able to fix them:

docs/physics/montecarlo/propagation.rst:39: WARNING: citation not found: Bjorkmann1999
docs/physics/plasma/nebular_plasma.rst:39: WARNING: citation not found: 1993A&A...279..447M
docs/physics/plasma/nebular_plasma.rst:63: WARNING: citation not found: 1993A&A...279..447M 

[isaacgsmith]

Perfect! I built it locally and everything is working!

[marxwillia]

@DhruvSondhi in order to speed up the review process, can you please include a link to your local build of the documentation for PR's like this one where you implement changes? See PR 1584 for an example.

[isaacgsmith]

@marxwillia I don't know if Dhruv got this fixed yet, but there was an issue with his documentation deploying. That's why I had just built it locally.

[DhruvSondhi]

Hello @marxwillia, Sorry for the late response 😓 . There is some problem with my GitHub Pages Documentation Deployment (as already mentioned by @smithis7 😄 ). I can generate the documentation from the gh-pages branch (all thanks to @epassaro 🙌🏼 ) which can be seen here but I cannot generate the docs from this branch apparently. I am trying to figure out where the problem could be lurking but it seems distant from a potential fix. If I can share the screenshots of the documentation thus built locally, would it be adequate?