Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numba deprecation #1571

Merged
merged 6 commits into from
May 20, 2021
Merged

Conversation

KevinCawley
Copy link
Contributor

@KevinCawley KevinCawley commented May 13, 2021

Fixes an old dependency on numba and updates the env file accordingly.

Description

This fixes the old use of jitclass to be now imported from numba.experimental, as well as making the numba dependency no longer fixed for tardis.

Motivation and context

Getting tardis added to the numba-integratino-testing pipeline

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@epassaro
Copy link
Member

/azp run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1571 (6f5a43c) into master (130475c) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 6f5a43c differs from pull request most recent head 5d586bb. Consider uploading reports for the commit 5d586bb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1571      +/-   ##
==========================================
+ Coverage   67.05%   67.20%   +0.14%     
==========================================
  Files          73       73              
  Lines        6144     6147       +3     
==========================================
+ Hits         4120     4131      +11     
+ Misses       2024     2016       -8     
Impacted Files Coverage Δ
...dis/montecarlo/montecarlo_numba/formal_integral.py 49.82% <0.00%> (+0.17%) ⬆️
tardis/tardis/base.py 55.00% <0.00%> (+49.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130475c...5d586bb. Read the comment docs.

@azure-pipelines
Copy link

Build failed 770f19f

Click here to see results.

@KevinCawley
Copy link
Contributor Author

Does this look good so far?

@epassaro
Copy link
Member

/azp run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Build succeeded 7b2b4c3

Click here to see results.

@KevinCawley
Copy link
Contributor Author

/azp run compare-refdata

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1571 in repo tardis-sn/tardis

@epassaro epassaro merged commit d361a22 into tardis-sn:master May 20, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Fix jitclass

* update numba version to not be fixed

* Move pickle5 to pip section

* Move pickle5 back to conda-forge

* Pin numba version to latest stable

* Leading 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants