Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fetch depth param to Azure template #1570

Merged
merged 5 commits into from
May 28, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented May 13, 2021

Description

Add the option to fetch n commits from the tip of tardis repo.

Motivation and context
Saves time and bandwidth per pipeline run.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1570 (59fcbac) into master (130475c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1570   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          73       73           
  Lines        6144     6144           
=======================================
  Hits         4120     4120           
  Misses       2024     2024           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130475c...59fcbac. Read the comment docs.

@epassaro epassaro force-pushed the select-fetch-depth branch from 0462624 to 0e629c2 Compare May 13, 2021 15:24
@andrewfullard andrewfullard self-requested a review May 14, 2021 17:40
@andrewfullard andrewfullard requested a review from wkerzendorf May 14, 2021 17:45
Copy link
Member

@wkerzendorf wkerzendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - would like to talk about CICD in general

@wkerzendorf wkerzendorf merged commit a069d1e into tardis-sn:master May 28, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* try fetch depth param

* update docs

* try python setup.py install

* minor changes

* minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants