Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring r_packet.py #1543

Merged
merged 4 commits into from
Apr 24, 2021

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Apr 21, 2021

Description

r_packet has been broken into additional files utils (containing utility functions, currently just the MonteCarloException class and get_random_mu), estimators (all estimator set/update), opacities (currently just tau electron), calculate_distances (all distance calls), frame_transformations (any doppler shifts or changes between frames)

Motivation and context

We need to clean up the r packet loops so that we can use the Monte Carlo framework for multiple different applications

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #1543 (cfc6052) into master (888575d) will increase coverage by 0.18%.
The diff coverage is n/a.

❗ Current head cfc6052 differs from pull request most recent head f9c2645. Consider uploading reports for the commit f9c2645 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1543      +/-   ##
==========================================
+ Coverage   69.06%   69.24%   +0.18%     
==========================================
  Files          68       73       +5     
  Lines        6106     6143      +37     
==========================================
+ Hits         4217     4254      +37     
  Misses       1889     1889              
Impacted Files Coverage Δ
...dis/tardis/montecarlo/montecarlo_numba/r_packet.py 27.64% <0.00%> (-3.34%) ⬇️
...s/montecarlo/montecarlo_numba/tests/test_packet.py 100.00% <0.00%> (ø)
.../montecarlo/montecarlo_numba/tests/test_vpacket.py 100.00% <0.00%> (ø)
...s/tardis/montecarlo/montecarlo_numba/estimators.py 52.63% <0.00%> (ø)
...ntecarlo/montecarlo_numba/frame_transformations.py 48.00% <0.00%> (ø)
...is/tardis/montecarlo/montecarlo_numba/opacities.py 83.33% <0.00%> (ø)
tardis/tardis/montecarlo/montecarlo_numba/utils.py 87.50% <0.00%> (ø)
...montecarlo/montecarlo_numba/calculate_distances.py 30.23% <0.00%> (ø)
tardis/tardis/montecarlo/montecarlo_numba/base.py 30.48% <0.00%> (+0.85%) ⬆️
.../montecarlo/montecarlo_numba/single_packet_loop.py 30.64% <0.00%> (+2.31%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888575d...f9c2645. Read the comment docs.

@wkerzendorf wkerzendorf merged commit 747390d into tardis-sn:master Apr 24, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* First restructure

* Clean up imports

* Fixed looping import

* Fix for numba_config import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants