Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes in git_workflow guide #1530

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Small fixes in git_workflow guide #1530

merged 1 commit into from
Apr 13, 2021

Conversation

Molkree
Copy link
Contributor

@Molkree Molkree commented Apr 9, 2021

Description

Just some typo fixes and updated GitHub links from HTTP to HTTPS.

Motivation and Context

Typos are self-explanatory, HTTPS saves your browser one redirect.

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • I have built docs locally, looks fine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

And http->https for GH links
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #1530 (db39ecf) into master (09f992f) will not change coverage.
The diff coverage is n/a.

❗ Current head db39ecf differs from pull request most recent head d8e519d. Consider uploading reports for the commit d8e519d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1530   +/-   ##
=======================================
  Coverage   67.57%   67.57%           
=======================================
  Files          68       68           
  Lines        6100     6100           
=======================================
  Hits         4122     4122           
  Misses       1978     1978           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f992f...d8e519d. Read the comment docs.

@Molkree
Copy link
Contributor Author

Molkree commented Apr 9, 2021

"The editing workflow" section suggests building docs with python setup.py build_sphinx however Documentation guidelines suggest to build with python setup.py build_docs or make html.
Is the latter preferred now?

@andrewfullard andrewfullard merged commit c14b2cd into tardis-sn:master Apr 13, 2021
@Molkree Molkree deleted the fixes_in_git_workflow_guide branch May 10, 2021 17:19
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
And http->https for GH links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants