Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Visualization Notebook Hyperlink #1505

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

KevinCawley
Copy link
Contributor

@KevinCawley KevinCawley commented Mar 21, 2021

This PR resolves #1500 regarding an outdated hyperlink.

Description

Changes the hyperlink so that it links properly.

Motivation and Context

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #1505 (59aca58) into master (47ed0ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1505   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          68       68           
  Lines        6040     6040           
=======================================
  Hits         4115     4115           
  Misses       1925     1925           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ed0ce...59aca58. Read the comment docs.

@andrewfullard andrewfullard merged commit 6e1cd85 into tardis-sn:master Mar 22, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperlink not working on a Documentation Page
3 participants