Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct .coveragerc file #1502

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

yuyizheng1112
Copy link
Contributor

Description

Here is a missing '\' in .coveragerc file in line 40. Although it is a simple modification, I think it should be done in case coverage check fails because of this.

Motivation and Context

I noticed #1419 so I went through .coveragerc file and found this mistake. Furthermore, I'd like to know whether I can make some additions to .coveragerc section to fix #1419 (e.g. add the montecarlo logger to the file).

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #1502 (9fba7d0) into master (9497250) will decrease coverage by 3.00%.
The diff coverage is n/a.

❗ Current head 9fba7d0 differs from pull request most recent head c59bb65. Consider uploading reports for the commit c59bb65 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   71.13%   68.12%   -3.01%     
==========================================
  Files          67       68       +1     
  Lines        5523     6040     +517     
==========================================
+ Hits         3929     4115     +186     
- Misses       1594     1925     +331     
Impacted Files Coverage Δ
tardis/tardis/plasma/properties/atomic.py 61.98% <0.00%> (-25.77%) ⬇️
tardis/tardis/plasma/standard_plasmas.py 73.11% <0.00%> (-10.84%) ⬇️
...s/tardis/plasma/properties/radiative_properties.py 78.14% <0.00%> (-4.08%) ⬇️
...is/tardis/plasma/properties/continuum_processes.py 39.20% <0.00%> (-4.04%) ⬇️
tardis/tardis/plasma/base.py 56.17% <0.00%> (-2.38%) ⬇️
tardis/tardis/plasma/properties/base.py 85.39% <0.00%> (-1.36%) ⬇️
tardis/tardis/plasma/properties/util/macro_atom.py 31.25% <0.00%> (-1.01%) ⬇️
tardis/tardis/io/atom_data/base.py 90.80% <0.00%> (-0.38%) ⬇️
...s/tardis/plasma/properties/property_collections.py 100.00% <0.00%> (ø)
...rdis/plasma/properties/transition_probabilities.py 32.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9497250...c59bb65. Read the comment docs.

@andrewfullard andrewfullard merged commit 47010f8 into tardis-sn:master Mar 23, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coverage failing too often
3 participants