Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring mistakes in #1145 #1492

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

chvogl
Copy link
Contributor

@chvogl chvogl commented Mar 17, 2021

This PR will fix some docstring errors from #1145.

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Not at all

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #1492 (e2b69da) into master (cf8900f) will not change coverage.
The diff coverage is n/a.

❗ Current head e2b69da differs from pull request most recent head 9b1f816. Consider uploading reports for the commit 9b1f816 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1492   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          68       68           
  Lines        6040     6040           
=======================================
  Hits         4115     4115           
  Misses       1925     1925           
Impacted Files Coverage Δ
...is/tardis/plasma/properties/continuum_processes.py 39.20% <0.00%> (ø)
...rdis/plasma/properties/transition_probabilities.py 32.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8900f...9b1f816. Read the comment docs.

@chvogl chvogl merged commit df65067 into tardis-sn:master Mar 22, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Fix docstring mistakes

* Fix more docstring mistakes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants