-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the symlink to visualization examples #1478
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
==========================================
- Coverage 67.57% 67.57% -0.01%
==========================================
Files 68 68
Lines 6100 6103 +3
==========================================
+ Hits 4122 4124 +2
- Misses 1978 1979 +1
Continue to review full report at Codecov.
|
This seems reasonable to me. The one thing we might want to consider is that the tardis_example.yml file is going to be living in multiple places in the repository. We should think about other ways to make our common example files easily accessible, while minimizing copies. @jaladh-singhal any thoughts? |
We use symbolic links for that file. The only real copy of @marxwillia is right though about accessibility. Perhaps we move the file somewhere easier to find, like just under |
Converting to draft until comments are addressed |
I second this. @yuyizheng1112 can you create a symlink to above path (as of now for this PR) instead of copying config file?
@marxwillia @andrewfullard where do you think is the best place to keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuyizheng1112 I think you're close, can you complete this PR with requested change (in comment above)?
4f36fa2
to
ed964fb
Compare
Sorry that I just saw your comment and thanks for your guidance! |
I am willing to take this task if the place of |
Description
Changes made:
Add the configuration file tardis_example.yml to the directory: docs/using/visualization.
Motivation and Context
In generating_widgets.ipynb and sdec_plot.ipynb, the file path of function
run_tardis()
is 'tardis_example.yml', which directs to the file in the same directory as notebooks. Therefore, the configuration file should be added to the directory.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: