-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option for keyword arguments in the TardisSpectrum's plot method #1477
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
=======================================
Coverage 71.13% 71.13%
=======================================
Files 67 67
Lines 5523 5523
=======================================
Hits 3929 3929
Misses 1594 1594 Continue to review full report at Codecov.
|
@wkerzendorf @epassaro Could you review it please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea to add.
probably this is on @jaladh-singhal side of the project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aribalam wow! very thoughtful 👍
* changed example according to new feature * [build docs]
Description
This PR is a feature request to facilitate the option of adding keyword arguments to the
plot
function of theTardisSpectrum
to provide more flexibility in plotting the spectrum using matplotlib.Motivation and Context
The current implementation of the
plot
function ofTardisSpectrum
does not provide any flexibility in plotting the spectrums.For example, using the Tardis Example setup, the spectrum plot in normal packet mode can be plotted using below code -
But in order to plot spectrums in different modes in the same figure with proper legends, the code is below -
With this feature, the code reduces down to -
Similarly, more customizations can be made to the plots this way, just by adding the required keyword arguments in the function the way it is done in matplotlib.
How Has This Been Tested?
Screenshots (if appropriate):
Given in Description
Types of changes
Checklist: