Reorganizing Models #1454
Merged
Reorganizing Models #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #1454 +/- ##
=======================================
Coverage 71.13% 71.13%
=======================================
Files 67 67
Lines 5523 5523
=======================================
Hits 3929 3929
Misses 1594 1594 Continue to review full report at Codecov.
|
andrewfullard
approved these changes
Feb 9, 2021
jaladh-singhal
approved these changes
Feb 17, 2021
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* reorganizing files * fixing a few warnings * moving some files around * merging models/examples/examples, models/examples/index, and models/examples/modelconfig into models/index * deleting models/csy/csv_test.ipynb * changing header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reorganizes the "Models" section of the documentation (
docs/using/components/models/) to include all relevant files, make the files more organized, and get rid of redundancies.Description
Changes include:
docs/using/components/modelsalong with all relevant files used. This includes moving the files fromdocs/yml_files/densitycustinto the the proper directory..../models/examples/examples.rst,.../models/examples/index.rst, and.../models/examples/modelconfig.rstinto.../models/index.rstto eliminate redundancies and extraneous files.run_simple_example.ipynbin.../models/examples/tardis_example.rst..../models/csy/csvy_test.ipynb.I organized this the way I thought it would work best. If that is not how it is supposed to be, please let me know. If you are reviewing this, you may want to take a look at that second bullet point to make sure no important information was lost.
Motivation and Context
This pull request addresses problems raised in issue #1437.
How Has This Been Tested?
I built the documentation locally. The number of warnings decreased, and everything built as expected.
Screenshots (if appropriate):
Types of changes
Documentation reorganization
Checklist: