Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Porting utility functions to C (issue #131) #142

Merged
merged 24 commits into from
Jun 3, 2014
Merged

WIP Porting utility functions to C (issue #131) #142

merged 24 commits into from
Jun 3, 2014

Conversation

orbitfold
Copy link
Contributor

This is a work in progress

orbitfold and others added 23 commits May 19, 2014 22:08
@orbitfold
Added compute_distance2inner and compute_distance2outer wrappers
49c0f0c
@orbitfold
Added tests for distance2outer
c5a3bfb
@orbitfold
Added tests for compute_distance2inner
a4352ba
@orbitfold
Added asv benchmarks for distance2outer and distance2inner
b5fabc3
@orbitfold
Reimplement compute_distance2outer and compute_distance2inner in C
9702107
@orbitfold
Make sure functions are inlined
e9dad8a
@orbitfold
Added doxygen comments to compute_distance2outer and compute_distance…
387094c 
…2inner
@orbitfold
Ported line_search to C
5440e2c
@orbitfold
Remove a misleading comment from binary_search
b0c0623
@orbitfold
Started porting StorageModel to C
844a0ab
@orbitfold
Don't inline binary_search and line_search
fe70f32
@orbitfold
Added parameter descriptions to the compute_distance2outer and comput…
cc1b3d2 
…e_distance2inner
@orbitfold
Added a wrapper for compute_distance2line
5e660b1
@orbitfold
Added a wrapper for compute_distance2electron
88cd3f2
Ported compute_distance2line to C
2f5ff99
Instead of raising an exception abort compute_distance2line
dcb72ea
Ported compute_distance2electron to C
1d4ae32
@orbitfold
Added tests for distance2line
cfdd185
@orbitfold
Added a test for distance2electron
6877e8e
@orbitfold
Replace compute_distance2line and compute_distance2electron with thei…
f72a388 
…r C counterparts
@orbitfold
Document distance2line
406d784
Added a description to distance2electron
b19bae4
Added benchmarks for distance2line and distance2electron
81ab8da
@orbitfold
Copy link
Contributor Author

Other than the issue off how to fail properly in distance2line this can be merged in.

@wkerzendorf
Copy link
Member

@orbitfold I have a very good reason for using the Exception-way to deal with this. If you use exit you will take down the underlying python session with it. That means an ipengine will die as a result of it, which is vital for dalek. Using a traceback will also show the user the general vicinity where this happened.

@orbitfold
Copy link
Contributor Author

This is ready to be merged in I think @ssim @mklauser can you give it a look?

@ssim
Copy link
Contributor

ssim commented Jun 3, 2014

@orbitfold I'm happy with this. Once Travis passes I will merge.

ssim added a commit that referenced this pull request Jun 3, 2014
@ssim
Merge pull request #142 from orbitfold/master
c7006e5 
WIP Porting utility functions to C (issue #131)
@ssim ssim merged commit c7006e5 into tardis-sn:master Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orbitfold @wkerzendorf @ssim