Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post reference data results #1410

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jan 12, 2021

Description

Several changes made to compare-refdata pipeline:

  • Pipeline is run by commenting /azp run compare-refdata on PR
  • Results are stored in OpenSupernova.org by PR number and commit
  • Results (failed or passing) are posted through comments by Azure Pipelines bots (see below)

Motivation and Context

Part of the CI project

How Has This Been Tested?

  • Testing pipeline
  • Other (please describe)

compare-refdata pipeline

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@epassaro
Copy link
Member Author

/azp run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1410 (9ab7de7) into master (9c5e24c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1410   +/-   ##
=======================================
  Coverage   71.18%   71.18%           
=======================================
  Files          67       67           
  Lines        5521     5521           
=======================================
  Hits         3930     3930           
  Misses       1591     1591           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5e24c...9ab7de7. Read the comment docs.

@azure-pipelines
Copy link

Build failed 080a718

Click here to see results.

remove conditional flags
@epassaro
Copy link
Member Author

/azp run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Build succeeded 5c94333

Click here to see results.

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs documentation ASAP!

@epassaro
Copy link
Member Author

Needs documentation ASAP!

Basic usage is already documented, could merge this and move on to next steps?

  • Compare reference data for any two arbitrary commits (currently we are just comparing HEAD of PR against upstream/master)
  • Update reference data from pipelines
  • Then, update documentation for good

@andrewfullard andrewfullard merged commit 9cab1ba into tardis-sn:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants