Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add black check workflow #1398

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Dec 21, 2020

Description

A simple action to run black --check tardis on every push to a PR.

Motivation and Context

Enforce PEP8.

How Has This Been Tested?

  • Testing pipeline
  • Other (please describe)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #1398 (dabe080) into master (e8ef961) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1398   +/-   ##
=======================================
  Coverage   70.04%   70.04%           
=======================================
  Files          67       67           
  Lines        5312     5312           
=======================================
  Hits         3721     3721           
  Misses       1591     1591           
Impacted Files Coverage Δ
tardis/tardis/widgets/tests/test_shell_info.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ef961...dabe080. Read the comment docs.

@epassaro epassaro added the CI/CD label Dec 22, 2020
missing python setup step

try changing workflow name

upgrade action version
Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epassaro thank you for making this - it was very necessary!

.github/workflows/black-check.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants