Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation build #1392

Merged
merged 4 commits into from
Dec 16, 2020
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Dec 16, 2020

Description

This is a continuation of @smithis7 PR #1387

  • Cleared notebook outputs (large diffs!)
  • Fixed softlinks (removed all files under schemas and make a link to the folder)
  • Add channel: conda-forge to workflow (again)
  • Pin sphinxcontrib-bibtex (see here)

Motivation and Context

Documentation build is failing repeatedly. Maybe due to some incompatibility with WSL symlinks (see here).

How Has This Been Tested?

See: https://github.com/epassaro/tardis/actions/runs/425646553

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #1392 (caa315c) into master (575c228) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1392   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files          66       66           
  Lines        5098     5098           
=======================================
  Hits         3690     3690           
  Misses       1408     1408           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575c228...caa315c. Read the comment docs.

@andrewfullard andrewfullard merged commit 23ac153 into tardis-sn:master Dec 16, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* pin sphinx-bibtex

* add channels param

* fix download link and clear outputs

* fix broken softlinks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants