Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for existing workflows #1384

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Dec 14, 2020

Description

A couple of small fixes

  • Fix not working update-changelog workflow
  • Supress warning on documentation-build workflow

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@@ -21,7 +21,6 @@ jobs:
with:
environment-file: tardis_env3.yml
activate-environment: tardis
channels: conda-forge, defaults
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Channels are already defined in tardis_env3.yml.

@@ -23,6 +23,7 @@ jobs:
- name: Commit files
run: |
git config --local user.email "[email protected]"
git config --local user.name "TARDIS bot"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required.

@epassaro epassaro added the CI/CD label Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #1384 (1a05f9a) into master (162f280) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1384   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files          66       66           
  Lines        5097     5097           
=======================================
  Hits         3690     3690           
  Misses       1407     1407           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162f280...1a05f9a. Read the comment docs.

@wkerzendorf wkerzendorf merged commit 77c2782 into tardis-sn:master Dec 14, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants