Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Plasma File in TOC #1378

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

isaacgsmith
Copy link
Member

Fixing a mistake in PR #1371.

Description

After renaming a file in PR #1371, docs/index.rst was not updated, and therefore docs/physics/plasma.rst does not show up in the main TOC. This change fixes it.

Motivation and Context

I opened an issue for this-- #1377 .

How Has This Been Tested?

I did test this, and plasma does appear in the sidebar.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@andrewfullard andrewfullard linked an issue Dec 9, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #1378 (5236056) into master (1c706d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1378   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files          66       66           
  Lines        5097     5097           
=======================================
  Hits         3690     3690           
  Misses       1407     1407           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c706d5...5236056. Read the comment docs.

@andrewfullard andrewfullard merged commit 6565a80 into tardis-sn:master Dec 9, 2020
@isaacgsmith isaacgsmith deleted the fixing_index branch December 11, 2020 18:23
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plasma missing from TOC
2 participants