Fixing issue #1357 #1364
Merged
Fixing issue #1357 #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
=======================================
Coverage 71.77% 71.77%
=======================================
Files 66 66
Lines 5077 5077
=======================================
Hits 3644 3644
Misses 1433 1433 Continue to review full report at Codecov.
|
andrewfullard
approved these changes
Dec 2, 2020
docs/team_and_governance/team.rst
Outdated
| * **Principal Investigator** | ||
| - Wolfgang Kerzendorf | ||
| * **TARDIS CORE** [alphabetical] | ||
| - Yssavo Camacho-Neves, Andreas Flörs, Alice Harpole, Vytautas Jancauskas, Wolfgang Kerzendorf (founder), Luke Shingles, Stuart Sim (founder), Christian Vogl, Marc Williamson |
There was a problem hiding this comment.
I should be in here too ;)
There was a problem hiding this comment.
@andrewfullard you're added!
|
@andrewfullard you're very quick - I had yet to review it! 😅 Even @smithis7 has some doubts I needed to answer because issue was created by me! |
There was a problem hiding this comment.
Great work @smithis7 🎉
Besides specific review comments, I have three more things to add:
- Take out "Accessing Physical Quantites" from Old Physics section to running/interaction - as shown in Restructure documentation to make sidebar look more informative #1357
- Rename title in CONTRIBUTING.md as "Contribution Guidelines"
- Make sure you delete the files from which you have extracted content to form new files like alumni.rst, goverance.rst, etc. - to make sure unnecessary files don't get piled up which will be difficult to remove later.
This was referenced Dec 6, 2020
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I restructured the TARDIS documentation to match the expected solution in issue #1357.
Description
I edited toctrees and created new files in order to get the documentation to look the proper way. I will have another pull request coming up that will delete the extraneous files resulting from these changes, as well as reorganizing files in the documentation's source code.
Motivation and Context
This pull request fixes issue #1357.
How Has This Been Tested?
I ran the documentation locally, and everything checked out (see the screenshot below-- I tested more than just that, but the screenshot shows that the scrollbar on the documentation matches the expected solution on issue #1357.
Screenshots (if appropriate):
Types of changes
Checklist: