Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new template to refdata pipeline #1310

Merged
merged 20 commits into from
Oct 14, 2020

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Sep 28, 2020

Needs tardis-sn/tardis-refdata#28 and #1308 to be merged.

Description

  • Minor changes to template (new package.manager variable and step names)
  • Apply new pipeline template to reference data template
  • Use Azure Repos mirror for fetching reference data
  • Update documentation
  • Add monthly cron trigger

Motivation and Context

Reviewing of the existing pipelines

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@epassaro epassaro marked this pull request as draft September 28, 2020 20:53
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot Sep 28, 2020
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot Sep 28, 2020
@tardis-sn tardis-sn deleted a comment from azure-pipelines bot Sep 28, 2020
@epassaro
Copy link
Member Author

/AzurePipelines run TARDIS refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1310 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1310   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files          46       46           
  Lines        3799     3799           
=======================================
  Hits         3099     3099           
  Misses        700      700           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cee3b2...112c6d4. Read the comment docs.

@wkerzendorf
Copy link
Member

is this a work in progress?

@epassaro
Copy link
Member Author

is this a work in progress?

It's mostly done. But need those two PR mentioned at the top of the description merged.

@wkerzendorf
Copy link
Member

okay this is pr #1310 - which says needs to be merged at the top

@epassaro
Copy link
Member Author

epassaro commented Oct 1, 2020

okay this is pr #1310 - which says needs to be merged at the top

Sorry, I was thinking of #1308 😂

@epassaro epassaro marked this pull request as ready for review October 12, 2020 22:32
@epassaro epassaro force-pushed the refdata-pipeline-review branch from 666f51a to a1c06bb Compare October 12, 2020 22:44
@epassaro
Copy link
Member Author

/AzurePipelines run TARDIS refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wkerzendorf wkerzendorf merged commit 156898a into tardis-sn:master Oct 14, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Initial commit

* Remove extra condition

* Enable pr trigger

* disable debug flag

* try comment trigger

* do not use mamba

* use mamba. use pytest instead of setup.py

* try run notebook

* set upstream remote

* remove condition

* pin nbconvert

* pin nbconvert

* minor changes

* unpin nbconvert

* use https repo again

* add extra packages parameter to template

* try extra packages parameter

* remove extra packages parameter, changes to step names

* add monthly cron trigger

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants