Remove pip install option from TARDIS installation docs

[jaladh-singhal]

pip install git+https://github.com/tardis-sn/tardis seems not to be working as mentioned in #1211 and as Anaconda suggests that pip should better be avoided with conda, so it needs to be removed from TARDIS installation docs to avoid any confusion for new users.

The only recommended way in our case is to use python setup.py install which is already mentioned in docs.

Motivation and Context

Avoid pip in conda and pip install not working but is still mentioned in docs

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have assigned/requested two reviewers for this pull request.

[codecov]

Codecov Report

Merging #1300 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1300   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files          41       41           
  Lines        3423     3423           
=======================================
  Hits         2757     2757           
  Misses        666      666           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862025e...c738838. Read the comment docs.

[epassaro]

I think the Installation guide now looks a bit redundant. If you are cloning the repo at some point then you don't need to get the environment file through curl or wget:

1. Clone the TARDIS repository
2. Install the dependencies with the YAML file in the repository
3. python setup.py install

Then, I don't think this closes #1211. Anaconda discourages the use of pip and that's fine. But it was possible to install TARDIS through pip and we break that at some point (and we don't know exactly why) so the bug still exists.

[epassaro]

I think the Installation guide now looks a bit redundant. If you are cloning the repo at some point then you don't need to get the environment file through curl or wget:

1. Clone the TARDIS repository
2. Install the dependencies with the YAML file in the repository
3. python setup.py install

Then, I don't think this closes #1211. Anaconda discourages the use of pip and that's fine. But it was possible to install TARDIS through pip and we break that at some point (and we don't know exactly why) so the bug still exists.

what do you think about this @jaladh-singhal ?

[wkerzendorf]

@jaladh-singhal the tests fail

[jaladh-singhal]

@wkerzendorf It's only for Mac pipeline due to that unrelated test

[jaladh-singhal]

Then, I don't think this closes #1211. Anaconda discourages the use of pip and that's fine. But it was possible to install TARDIS through pip and we break that at some point (and we don't know exactly why) so the bug still exists.

@epassaro this makes sense, I agree it shouldn't closed #1211 - I've removed that from description

I think the Installation guide now looks a bit redundant. If you are cloning the repo at some point then you don't need to get the environment file through curl or wget:

This is true @epassaro but we still need to make sure that pip install isn't recommended until we fix it. So either I can change the wording to "Clone TARDIS Repo -> Create env (without curl/wget ofc) -> setup.py install. Or the other way is we leave it as it is and mark it "not working currently" or something and put setup.py install section (without curl/wget) before it, marking as "recommended way as of now". Let me know which one do you prefer?

[epassaro]

Then, I don't think this closes #1211. Anaconda discourages the use of pip and that's fine. But it was possible to install TARDIS through pip and we break that at some point (and we don't know exactly why) so the bug still exists.

@epassaro this makes sense, I agree it shouldn't closed #1211 - I've removed that from description

I think the Installation guide now looks a bit redundant. If you are cloning the repo at some point then you don't need to get the environment file through curl or wget:

This is true @epassaro but we still need to make sure that pip install isn't recommended until we fix it. So either I can change the wording to "Clone TARDIS Repo -> Create env (without curl/wget ofc) -> setup.py install. Or the other way is we leave it as it is and mark it "not working currently" or something and put setup.py install section (without curl/wget) before it, marking as "recommended way as of now". Let me know which one do you prefer?

I prefer the first option.