-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add widgets documentation to tardis docs #1280
Add widgets documentation to tardis docs #1280
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
11b8e3b
to
2467c3d
Compare
2467c3d
to
0d20076
Compare
Codecov Report
@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
- Coverage 81.75% 81.57% -0.18%
==========================================
Files 44 46 +2
Lines 3699 3799 +100
==========================================
+ Hits 3024 3099 +75
- Misses 675 700 +25 Continue to review full report at Codecov.
|
0d20076
to
ee149f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work @jaladh-singhal! Very well documented. Happy for this to be merged, pending review of my comments
ee149f5
to
0f4c96c
Compare
0f4c96c
to
44f0b0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment regarding grammar, but otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me.
…widgets-doc Add widgets documentation to tardis docs
It adds documentation of widgets to tardis docs by creating a directory
tardis_widgets
having:using_widgets.rst
- For description about how to use widgets and their featuresgenerating_widgets.ipynb
- Demo notebook to generate widgets