Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space to plasma error message #1274

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Add space to plasma error message #1274

merged 1 commit into from
Sep 30, 2020

Conversation

arjunsavel
Copy link
Contributor

@arjunsavel arjunsavel commented Aug 13, 2020

Description

I've added a space to an error message in plasma/standard_plasmas.py.

Motivation and Context

When the link in this error message is printed out, it currently includes ",for" at the end of the link itself — leading the user to a broken page.

How Has This Been Tested?

N/A (I think!)

Screenshots (if appropriate):

Screen Shot 2020-08-13 at 5 00 20 PM
Screen Shot 2020-08-13 at 4 54 50 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #1274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1274   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files          41       41           
  Lines        3428     3428           
=======================================
  Hits         2762     2762           
  Misses        666      666           
Impacted Files Coverage Δ
tardis/plasma/standard_plasmas.py 83.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94f292...da52be2. Read the comment docs.

@marxwillia marxwillia merged commit aa7c384 into master Sep 30, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants