Update package versions #1262
Merged
Update package versions #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 80.63% 80.63%
=======================================
Files 41 41
Lines 3424 3424
=======================================
Hits 2761 2761
Misses 663 663 Continue to review full report at Codecov.
|
wkerzendorf
reviewed
Aug 4, 2020
| @@ -44,8 +44,7 @@ jobs: | |||
| displayName: "Install TARDIS environment" | |||
|
|
|||
| - bash: | | |||
| echo git clone $(ref.data.github.url) $(ref.data.home) | |||
| git clone $(ref.data.github.url) $(ref.data.home) | |||
| GIT_LFS_SKIP_SMUDGE=1 git clone $(ref.data.github.url) $(ref.data.home) | |||
wkerzendorf
reviewed
Aug 4, 2020
wkerzendorf
reviewed
Aug 4, 2020
tardis_env3.yml
Outdated
| @@ -21,7 +21,7 @@ dependencies: | |||
| # I/O | |||
| - pyyaml | |||
| - jsonschema | |||
| - pyne=0.5 | |||
| - pyne | |||
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* Unpin packages * Pin numpy to 1.15 again * Pin numba to v0.50 * [skip-ci] Remove Git LFS directive * [skip-ci] (revert) Remove Git LFS directive * Pin pyne to v0.7 * Trying to find problem in macOS env * Trying to find problem in macOS env (2) * Trying to find problem in macOS env (3) * Trying to find problem in macOS env (4) * Remove all the pins * Add some pins * Add some pins (2) * Pin numpy to v1.16 * Pin numpy to v1.17 * Pin numpy to v1.16 and scipy to v1.5 * Pin numba to v0.50 * Pin pyne to v0.7 * [skip-ci] Remove Git LFS directive * [skip-ci] Remove Git LFS directive (2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A segmentation fault is occurs after running:
pytest tardis/plasma/tests/test_hdf_plasma.py --tardis-refdata=path/to/tardis-refdataThis problem started right after recent
pyneupdate:pyneupdate inconda-forgetriggered Python update from 3.6 to 3.7.8.numbais aggressively pinned to 0.43 in TARDIS environment file.numba0.43 has a bug in Python >=3.7.4 that leads to a segmentation fault (see: numba segmentation fault on Python 3.7.4 numba/numba#4323).Upgrading
numba>=0.45solves the issue.NOTE: macOS environment still uses
pyne=0.5after resolving dependencies with unpinnedpyne, that's why I'm not unpinningnumpyyet.Motivation and Context
This change would make our test suite to work again.
How Has This Been Tested?
With @Rodot-'s help debugged our code using GDB, and the result was:
Screenshots (if appropriate):
Types of changes
Checklist: