Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how virtual_packet properties are saved in hdf #1254

Merged

Conversation

jaladh-singhal
Copy link
Member

This PR makes sure that vpacket logging status is determined at run-time, thus removes any need of saving to a config file.

Description

Motivation and Context

Fixes #1246

How Has This Been Tested?

  • Saved simulation to hdf file with vpacket-logging enabled, all vpacket_hdf_properties get saved.
  • Saved simulation to hdf file with vpacket-logging disabled, none of the vpacket_hdf_properties get saved.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@jaladh-singhal jaladh-singhal force-pushed the fix-vpacket-logging-check branch from 4acf86f to 03ce0b8 Compare August 4, 2020 15:33
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #1254 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage   80.63%   80.60%   -0.03%     
==========================================
  Files          41       41              
  Lines        3424     3419       -5     
==========================================
- Hits         2761     2756       -5     
  Misses        663      663              
Impacted Files Coverage Δ
tardis/io/util.py 73.29% <50.00%> (-0.27%) ⬇️
tardis/montecarlo/base.py 87.50% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d31e09...03ce0b8. Read the comment docs.

@wkerzendorf wkerzendorf merged commit 428005d into tardis-sn:master Sep 2, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Removed code that saved vpacket properties using config file

* Add vpacket properties to hdf if virt_logging enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix how vpacket-logging status is saved
3 participants