Re-applied Black formatting to tardis after excluding undesired directories #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
=======================================
Coverage 77.71% 77.71%
=======================================
Files 91 91
Lines 5727 5727
=======================================
Hits 4451 4451
Misses 1276 1276
Continue to review full report at Codecov.
|
jaladh-singhal
commented
Jun 30, 2020
There was a problem hiding this comment.
@wkerzendorf On reviewing each file, these are the changes I think we'll require - otherwise everything looks good to me! Please if you can, take a moment to see anything else you may find!
And if these changes seem fine by you, let me know - I'll do a batch commit.
jaladh-singhal
force-pushed
the
black-config
branch
from
11d62b8 to
a2de4c4
Compare
|
Excluded |
wkerzendorf
approved these changes
Jul 8, 2020
harpolea
approved these changes
Jul 20, 2020
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
…tories (tardis-sn#1213) * Added directories to exclude in black configuration file * Added black to tardis environment file * Excluded setup related files from black configuration * Applied black formatting to remaining files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to exclude undesired directories from black formatting. When running black, there are still 10 files which were formatted blacked (which were not covered earlier run, because it was run not on root of project but inside
tardis/).A brief summary of changes in each file are:
pyproject.toml- Added directories to exclude from black (includingastropy_helperswhich was being formatted by black)tardis_env3.yml- Added black as a code quality dependency, so that it is already installed in a new tardis environmenttardis/plasma/- 2 files - they are actually one line changes, made by us @wkerzendorf when editing strings - those strings were quite long, so black line-breaked them as expected ✅docs/- There are 4 python files inside itasv/- 1 fileah_bootstrap.py,setup.py,ez_setup.pyare remaining 3 at root directory.Motivation and Context
Related #1201
How Has This Been Tested?
They're only formatting changes so ideally they shouldn't break the code. And if test pipeline pass, they are good to merge.