Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin astropy version #1193

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Unpin astropy version #1193

merged 1 commit into from
Jun 19, 2020

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 19, 2020

Description

Change astropy required version from tardis_env3.yml

Motivation and Context

astropy was pinned strictly to v3.2.1 after accidentally merging #995.

How Has This Been Tested?

All test pass.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #1193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files          89       89           
  Lines        5551     5551           
=======================================
  Hits         4282     4282           
  Misses       1269     1269           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e1831...d73baec. Read the comment docs.

Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and doesn't seem to break anything at the moment.

@wkerzendorf wkerzendorf merged commit 2faf0ef into tardis-sn:master Jun 19, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants