Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pytestconfig to request.config #1190

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 17, 2020

Description

Closes issue #1186.

Motivation and Context

See the issue description.

How Has This Been Tested?

All tests pass.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1190 into master will not change coverage.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1190   +/-   ##
=======================================
  Coverage   77.71%   77.71%           
=======================================
  Files          91       91           
  Lines        5727     5727           
=======================================
  Hits         4451     4451           
  Misses       1276     1276           
Impacted Files Coverage Δ
tardis/tests/integration_tests/test_integration.py 26.58% <0.00%> (ø)
tardis/montecarlo/tests/test_packet_source.py 86.36% <57.14%> (ø)
tardis/plasma/tests/test_complete_plasmas.py 97.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47075d...d78bfb2. Read the comment docs.

@epassaro
Copy link
Member Author

I don't know why Codecov is -2%, doesn't have sense.

@epassaro epassaro requested review from Rodot- and wkerzendorf June 17, 2020 16:03
@epassaro epassaro assigned epassaro, wkerzendorf and Rodot- and unassigned epassaro Jun 17, 2020
@Rodot-
Copy link
Contributor

Rodot- commented Jun 17, 2020

This is odd, looks like something might be wrong with the changes to test_integration.py?

@epassaro
Copy link
Member Author

epassaro commented Jun 19, 2020

I don't think so.

Seems codecov calculates the % of coverage by the length of the tests or something like that. Now our tests are exactly the same but shorter in number of lines or something.

Also I deleted a docstring by mistake, already fixed it.

@epassaro epassaro force-pushed the pytest-config-to-request branch from cf48c24 to d78bfb2 Compare June 29, 2020 00:00
@wkerzendorf wkerzendorf merged commit abfbd48 into tardis-sn:master Jul 6, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Change `pytestconfig` to `request.config`

* Removed docstring by mistake. Fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants