Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line info widget to TARDIS: demo notebook #1187

Closed

Conversation

jaladh-singhal
Copy link
Member

This PR aims to share a notebook for experimentation and code that will be used to create line info widgets.

NOTE: This is not intended for merging.

Motivation and Context

This a part of GUI project to create line info widget for TARDIS.

How Has This Been Tested?

All the code in notebook works fine by executing cells.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #1187 into master will increase coverage by 2.90%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1187      +/-   ##
==========================================
+ Coverage   77.73%   80.63%   +2.90%     
==========================================
  Files          92       41      -51     
  Lines        5731     3424    -2307     
==========================================
- Hits         4455     2761    -1694     
+ Misses       1276      663     -613     
Impacted Files Coverage Δ
tardis/io/util.py 73.56% <0.00%> (ø)
tardis/io/decay.py 89.65% <0.00%> (ø)
tardis/util/base.py 77.77% <0.00%> (ø)
tardis/plasma/base.py 58.27% <0.00%> (ø)
tardis/widgets/base.py 93.85% <0.00%> (ø)
tardis/io/model_reader.py 97.70% <0.00%> (ø)
tardis/io/parsers/csvy.py 89.74% <0.00%> (ø)
tardis/io/atom_data/base.py 91.17% <0.00%> (ø)
tardis/io/atom_data/util.py 47.05% <0.00%> (ø)
tardis/io/parsers/stella.py 0.00% <0.00%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a6b36...2a85172. Read the comment docs.

@jaladh-singhal jaladh-singhal force-pushed the widgets/line-info-demo branch from 5314bad to e141f0f Compare June 24, 2020 20:25
@wkerzendorf
Copy link
Member

@jaladh-singhal is this still relevant

@jaladh-singhal
Copy link
Member Author

This PR is no longer relevant since line-info-widget has already been pushed under #1264 so closing it for now.

The notebook in this PR will be useful in future though to check out prototypes and other possible options we can use to add more features in Line Info Widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants