Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mailmap #1178

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Update mailmap #1178

merged 1 commit into from
Jun 1, 2020

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 1, 2020

Description

Fix @Rodot- incomplete name.

Motivation and Context

Complete author names are required to release TARDIS versions.

How Has This Been Tested?

Ran gather_data.ipynb from tardis_zenodo repo locally in my computer.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

arjunsavel
arjunsavel approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@arjunsavel arjunsavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Confirmed this by running gather_data.ipynb locally.

@wkerzendorf wkerzendorf merged commit 92f2f05 into tardis-sn:master Jun 1, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
@epassaro
Fix Jack O`Brien and Jordi Eguren author names (tardis-sn#1178)
77e1ea2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjunsavel arjunsavel arjunsavel approved these changes

@wkerzendorf wkerzendorf Awaiting requested review from wkerzendorf

Assignees

@wkerzendorf wkerzendorf

@arjunsavel arjunsavel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epassaro @arjunsavel @wkerzendorf