Create a new subpackage for jupyter-widgets and add shell info widgets #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaladh-singhal
force-pushed
the
widgets/submodule
branch
from
fac7c4c to
09db61b
Compare
wkerzendorf
reviewed
Jun 2, 2020
wkerzendorf
reviewed
Jun 2, 2020
wkerzendorf
reviewed
Jun 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #1166 +/- ##
==========================================
+ Coverage 77.13% 77.73% +0.59%
==========================================
Files 89 92 +3
Lines 5551 5731 +180
==========================================
+ Hits 4282 4455 +173
- Misses 1269 1276 +7
Continue to review full report at Codecov.
|
wkerzendorf
reviewed
Jun 3, 2020
jaladh-singhal
commented
Jun 5, 2020
jaladh-singhal
force-pushed
the
widgets/submodule
branch
from
72932b9 to
19fad50
Compare
wkerzendorf
reviewed
Jun 12, 2020
wkerzendorf
reviewed
Jun 12, 2020
wkerzendorf
reviewed
Jun 12, 2020
ycamacho
reviewed
Jun 16, 2020
- Notes section wasn't visible - Other parameters section was being rendered incorrectly - External links & inline code blocks were also incorrect
wkerzendorf
approved these changes
Jun 19, 2020
ycamacho
approved these changes
Jun 19, 2020
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
tardis-sn#1166) * Create a widgets submodule * Creat a class for shell info with functions to extract tables data * Put all shell info widget code in its class * Debugged several logical errors in code due to copying * Import main ShellInfoWidget class in init.py * Removed default simulation argument from ShellInfoWidget class * Created one method for creating 4 different table widgets in init * Separated shell info data into HDF and Simulation child class * Made ShellInfoWidget work with both HDF & simulation object * Imputed NaN count values wih 0 * Fixed settingwithcopy error in Z_count_table * Added widgets notebook to be put in docs and shell info demo gif * Refactored Z to element and atomic_num to respect PEP8 * Added docstrings to multiple functions and classes * Converted 2 interdependent optional args of create_table_widget as 1 dict * Added some docstrings and improved signature of display function * Updated the way of accessing shell info widget from hdf and simulation * Added unit tests for shwll info data * Added tests for ion_count and element_count * Added tests for shell info widget * Added qgrid to tardis env file * Added jupyter-widgets notebook to index * Several fixes to docstrings - Notes section wasn't visible - Other parameters section was being rendered incorrectly - External links & inline code blocks were also incorrect * Fixed typo in widgets notebook * Applied black formatter to cover all pep8 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily aims to make shell info jupter-widgets accessible via
widgetssubpackage. The code is put together in a class in submodulebase.py(as of now) along with relevant tests and documentation.Things to do: