-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update doc page to a notebook #1153
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change — I'm very much for having more notebooks in the documentation! A few clarifications regarding changes (these are probably fine, just wanted to check):
- Does the information exist in radial1d or Simulation? Could they be accessed directly from radial1d?
- Similarly regarding the change from accessing tardis_config to accessing model
One thing that I would add is mentioning the use of AstroPy Quantities for simulation.model.v_inner.cgs and related quantities.
Other than that, I'm ready to approve this.
The physical quantities are mostly either in
As mentioned by @chvogl in the chats,
Okay, I will update that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
* update doc page to a notebook * fix errors * mention units as Astropy Quantities wherever present
Updated physical quantitities page to a jupyter notebook