Fix the Plasma tests #1150
Merged
Fix the Plasma tests #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkerzendorf
force-pushed
the
tests/fix_plasma_test
branch
2 times, most recently
from
055d62e to
84759d8
Compare
wkerzendorf
force-pushed
the
tests/fix_plasma_test
branch
from
84759d8 to
3b4d5bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
- Coverage 77.29% 77.13% -0.16%
==========================================
Files 90 89 -1
Lines 5589 5551 -38
==========================================
- Hits 4320 4282 -38
Misses 1269 1269
Continue to review full report at Codecov.
|
|
Seems fine. Maybe would be a good idea to change the title of the PR to something more informative (about codecov and deleting tests) to find this in the future (if necessary). |
epassaro
approved these changes
May 29, 2020
chvogl
approved these changes
Jun 2, 2020
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* fix some PEP8 * removed PEP8 violations * remove tests plasma test_plasmas_full * fix coverage problem * add token * use upstream/master azure yml and add token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Progress ... Do not merge
There are currently several tests for the plasma calculation. Time to take inventory and clean up
Description
Fix up PEP8
Try to delete some tests and see if the coverage changes
Motivation and Context
There seem to be many tests and it is unclear which one them are still needed. We will delete and see if coverage changes.
How Has This Been Tested?
N/A